Potential fix for handling small files #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `read -rn 8` command doesn't seem to cope with small files, and does all kinds of strange things when I try running it manually on latest macOS to test, including: - not reading anything at all from files with short first lines - reading too much from files with long first lines (more than 8 chars) Overall the `head -c8` approach used everywhere else to do this work is probably safer, and should work with small files as well.
elasticdog
approved these changes
Apr 26, 2021
There was a problem hiding this comment.
Thanks @jmurty for the fix here and for adding tests. Hopefully the user can confirm the fix, but this approach is good with me 👍
With this change — especially the use of `printf` instead of `echo` to write file contents — this test case should actually do some useful work.
* main: Improve command hint to fix secret files not encrypted in index (#120) (#130) Remove Ubuntu 16.04 LTS from test matrix (#123) Configure default Git branch name for macOS tests in GitHub Handle rename of primary branch from "master" to "main" Ensure Git index is up-to-date before dirty repo check #37 (#109) Fix incorrect salt when partially staged files are commited (#119) Use shorthand for grep options for broader compatibility (#121)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #116
The
read -rn 8command doesn't seem to cope with small files, anddoes all kinds of strange things when I try running it manually on
latest macOS to test, including:
Overall the
head -c8approach used everywhere else to do this workis probably safer, and should work with small files as well.