Fix realpath implementation #38
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous implementation wrongly returned the current directory - for some existing inputs, e.g. "/" or "/etc", - for some not existing inputs, e.g. "/no_such_name/" or "/etc/no_such_name/" or "no_such_name/", - for the empty string. The latter made the safety check for an existing git repository always pass, leading to a bunch of errors when run outside of a repository.
|
Thank you very much for fixing this! I really appreciate the contribution and am thinking I need to get some testing into place as more and more transcrypt functionality gets added. I've already merged your code into master and am currently traveling, but will try and cut a new release when I have some downtime. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous implementation wrongly returned the current directory
"/etc/no_such_name/" or "no_such_name/",
The latter made the safety check for an existing git repository always
pass, leading to a bunch of errors when run outside of a repository.