Fix OpenSSL v1.1+ incompatibility #48
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- `list-ciphter-commands` is `list -cipher-commands` in OpenSSL versions 1.1+ - this fix maintans backwards compatibility with older OpenSSL versions
|
@elasticdog can you please have a look at this? It would be really great if you could review and merge soon if this is ok :) |
|
@cdimitroulas Thanks for the ping here...I was heading home from a 3 month trip abroad when this PR came in, and I forgot to revisit. @Aramgutang Very nice, thank you for the PR! ⭐️ I was glad to see you maintain the backward compatibility. I like this approach much better than trying to parse version numbers. There were a few things that I thought could be cleaned up, but I went ahead and merged this into the master branch and then cleaned up the logic in a separate commit. Please give it a shot and let me know if you experience any issues. I'll work on cutting a new release shortly. |
This was referenced May 25, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In OpenSSL 1.1, the equivalent of
list-cipher-commandsis nowlist -cipher-commands, and the former is no longer supported.This fix maintains backwards compatibility by checking which of the commands succeed first, and use the working one in the subsequent code.