-
Notifications
You must be signed in to change notification settings - Fork 4
Revise Write Xml #31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revise Write Xml #31
Conversation
"_attr": { | ||
"id": "my id" | ||
}, | ||
"_": "my inner text" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So '_' or '#'?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As per the documentation charKey
defaults to _
though it was #
in earlier versions. We can change it to whatever we want though...
@@ -1,6 +1,9 @@ | |||
{ | |||
"title": "XML", | |||
"description": "Component to work with XML files", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll change that back. I guess that component level descriptions still appear even though action/trigger level descriptions are not longer rendered. Asking for follow up: https://elasticio.slack.com/archives/C6G1E4WB1/p1587374522293600
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Platform issue: https://github.com/elasticio/elasticio/issues/3816
"title": "JSON to XML", | ||
"main": "./lib/actions/jsonToXml.js", | ||
"help": { | ||
"link": "#json-to-xml", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
after docs on docs.elastic.io updated would need to check if this link still valid
Resolves #30