Skip to content

Revise Write Xml #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 20 commits into from
Apr 22, 2020
Merged

Revise Write Xml #31

merged 20 commits into from
Apr 22, 2020

Conversation

jhorbulyk
Copy link
Contributor

Resolves #30

"_attr": {
"id": "my id"
},
"_": "my inner text"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So '_' or '#'?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@@ -1,6 +1,9 @@
{
"title": "XML",
"description": "Component to work with XML files",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there any specific reason why the component description is removed?
image

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll change that back. I guess that component level descriptions still appear even though action/trigger level descriptions are not longer rendered. Asking for follow up: https://elasticio.slack.com/archives/C6G1E4WB1/p1587374522293600

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"title": "JSON to XML",
"main": "./lib/actions/jsonToXml.js",
"help": {
"link": "#json-to-xml",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

after docs on docs.elastic.io updated would need to check if this link still valid

@jhorbulyk jhorbulyk merged commit bb0231e into master Apr 22, 2020
@jhorbulyk jhorbulyk deleted the revise-write-xml branch April 22, 2020 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add revised write XML action
4 participants