Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated @moltin/sdk to v4.0.0 #52

Merged
merged 2 commits into from
Aug 14, 2020
Merged

Updated @moltin/sdk to v4.0.0 #52

merged 2 commits into from
Aug 14, 2020

Conversation

dusanradovanovic
Copy link
Contributor

@dusanradovanovic dusanradovanovic commented Aug 14, 2020

Description:

This PR updates all moltin types to the v4.0.0. There are no additional custom types declared in service.ts since they are being imported from the sdk. Instead of that there is only a short extensions.d.ts file that defines only properties added through flows.

Linting:

  • No linting errors

Tests:

  • E2E tests
  • Manual tests
  • Accessibility tests (no new react-axe errors in console)

Documentation:

  • Requires documentation updates
  • Requires Storybook component updates

@shaunmaharaj shaunmaharaj merged commit 4a633ca into master Aug 14, 2020
@shaunmaharaj shaunmaharaj deleted the sdk-v4 branch August 14, 2020 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants