Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes hardcoded Algolia index for price asc/desc #56

Merged
merged 1 commit into from
Aug 25, 2020
Merged

Fixes hardcoded Algolia index for price asc/desc #56

merged 1 commit into from
Aug 25, 2020

Conversation

mwan-ep
Copy link
Contributor

@mwan-ep mwan-ep commented Aug 21, 2020

Description:

Changes the index name for price ascending/descending Algolia replicas to begin withConfig.AlgoliaIndexName instead of the hardcoded value product.

Linting:

  • No linting errors

Tests:

  • E2E tests
  • Manual tests
    • Verified price_asc/desc work for Algolia replicas using the Config.AlgoliaIndexName
  • Accessibility tests (no new react-axe errors in console)

Documentation:

  • Requires documentation updates
  • Requires Storybook component updates

@shaunmaharaj
Copy link
Contributor

Thank you for this @mwan-ep!

@shaunmaharaj shaunmaharaj merged commit 7e3008e into master Aug 25, 2020
@shaunmaharaj shaunmaharaj deleted the fix/sortby branch August 25, 2020 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shaunmaharaj shaunmaharaj shaunmaharaj approved these changes

@rostyk-kanafotskyy rostyk-kanafotskyy rostyk-kanafotskyy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mwan-ep @shaunmaharaj @rostyk-kanafotskyy