Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for language when calling APIs #57

Merged
merged 2 commits into from
Aug 26, 2020
Merged

Conversation

dusanradovanovic
Copy link
Contributor

Description:

Passing selected language to API endpoints that support it. This allows localized product names/description etc when configured properly on the backend.

Linting:

  • No linting errors

Tests:

  • E2E tests
  • Manual tests
  • Accessibility tests (no new react-axe errors in console)

Documentation:

  • Requires documentation updates
  • Requires Storybook component updates

@shaunmaharaj
Copy link
Contributor

Thanks @dusanradovanovic, this looks great! Can we include an update in this PR to pull the latest version of the JS-SDK too? Currently we’re pulling 4.0.0, but you pushed an update last week. Thank you!

@dusanradovanovic dusanradovanovic merged commit d664729 into master Aug 26, 2020
@dusanradovanovic dusanradovanovic deleted the api-language branch August 26, 2020 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants