Display error messages #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| return ( | ||
| <div className="notification"> | ||
| {!!error && error.length > 0 && error.map((el: IErrorMessage) => ( | ||
| <div className="notification__body" key={`${el.detail}_${Math.random().toString(36)}`}> |
There was a problem hiding this comment.
I look forward to when we can get error message keys from the API to populate this 😄
| @@ -34,6 +36,7 @@ export const Promotion: React.FC<PromotionProps> = (props) => { | |||
| }) | |||
| .catch(error => { | |||
| console.error(error); | |||
| addError(error.errors); | |||
There was a problem hiding this comment.
Do we still need to call setErrors if we're displaying our own toast?
There was a problem hiding this comment.
@shaunmaharaj,
I think we should display only our own toast. I'll update it.
That's actually what I told before. Should we use the state of a component or our own toast for displaying messages (the same is in address form, login form, and registration form)?
| import { getCustomer, getAddresses, getAllOrders, loadCategoryTree, getCartItems } from './service'; | ||
| import * as service from './service'; | ||
| import { | ||
| getCustomer, |
There was a problem hiding this comment.
Thanks for cleaning this up!
shaunmaharaj
approved these changes
Oct 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Linting:
Tests:
Documentation: