Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Header and footer are set by variable in common.scss #73

Merged

Conversation

maennis-ep
Copy link
Contributor

Description:
Removed some hardcoded colors and added a new variable in common.scss to change the header and footer background color.

Linting:

  • No linting errors

Tests:

  • E2E tests
  • Manual tests
    Change the value of $mainNavigationBackgroundColor value in common.scss and see the header and footer change color
  • Accessibility tests (no new react-axe errors in console)

Documentation:

  • Requires documentation updates
  • Requires Storybook component updates

@netlify
Copy link

netlify bot commented Nov 4, 2020

Deploy request for staging-epcc-ref-store accepted.

Accepted with commit 5cb8193

https://app.netlify.com/sites/staging-epcc-ref-store/deploys/5fa1ef1779b90c0007f935b2

@netlify
Copy link

netlify bot commented Nov 4, 2020

Deploy request for integration-epcc-ref-store accepted.

Accepted with commit 5cb8193

https://app.netlify.com/sites/integration-epcc-ref-store/deploys/5fa1ef1735790500079b89b7

@shaunmaharaj shaunmaharaj merged commit 3847add into elasticpath:master Nov 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants