Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Countries select implemented #84

Merged
merged 1 commit into from
Nov 25, 2020
Merged

Countries select implemented #84

merged 1 commit into from
Nov 25, 2020

Conversation

butikden
Copy link
Contributor

@butikden butikden commented Nov 24, 2020 •
edited
Loading

Description:
CountriesSelect component is added.
countriesList.json file data is added from https://github.com/fannarsh/country-list/blob/master/data.json according to ISO 3166-1-alpha-2

Linting:

  • No linting errors

Tests:

  • E2E tests
  • Manual tests
  • Accessibility tests (no new react-axe errors in console)

Documentation:

  • Requires documentation updates
  • Requires Storybook component updates

@butikden butikden self-assigned this Nov 24, 2020
@shaunmaharaj
Copy link
Contributor

This looks great to me. Thanks for this @butikden!
We'll merge after confirming QA with UX first.

@BonnieEP
Copy link

Looks good! Thanks for this update

@shaunmaharaj shaunmaharaj merged commit 533512a into master Nov 25, 2020
@shaunmaharaj shaunmaharaj deleted the RS-872-countries-select-added branch November 25, 2020 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shaunmaharaj shaunmaharaj shaunmaharaj approved these changes

Assignees

@butikden butikden

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@butikden @shaunmaharaj @BonnieEP