Removed component initialization and started importing intl from library. #651
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dusanradovanovic
requested review from
yulia-dnistrian,
aChanEP,
petro97,
rostyk-kanafotskyy and
shaunmaharaj
rostyk-kanafotskyy
approved these changes
Mar 23, 2020
petro97
approved these changes
Mar 23, 2020
yulia-dnistrian
approved these changes
Mar 23, 2020
aChanEP
reviewed
Mar 23, 2020
aChanEP
reviewed
Mar 24, 2020
|
Need to address conflict in PR |
…the react-scripts to fix breaking change
addressed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This is the first part of a two part refactor. In this part I removed
intlobject fromgetConfig()and started importing it in components directly from library.getConfig()also now returns inlined epConfig object and does not require initialization anymore.Linting:
Component Updates:
Tests:
e2e)Documentation: