Convert less files to sass #675
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dusanradovanovic
requested review from
yulia-dnistrian,
aChanEP,
rostyk-kanafotskyy and
shaunmaharaj
shaunmaharaj
approved these changes
Apr 28, 2020
aChanEP
reviewed
Apr 28, 2020
|
@dusanradovanovic Documentation is queued up for deployment. Can push to prod once this is merged 👍 Thanks for the great work on this one! |
aChanEP
approved these changes
Apr 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR converts all
.lessstyles to '.sass' styles. Two languages have very similar syntax (https://sass-lang.com/guide), however Sass is much more popular these days. It is also supported OOTB by the create-react-app which will ease the transition of "un-ejecting" from default CRA.Linting:
Tests:
e2e)Documentation: