Lazy load b2b Bulk Order & Barcode Scanner #682
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aChanEP
changed the title
dusanradovanovic
approved these changes
May 1, 2020
|
LGTM! Thanks @aChanEP! 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
https://elasticpath.atlassian.net/browse/RS-795
This PR makes it so that bulk order, barcode scanner and all its dependancies will not be pulled down when in B2C mode.
In B2B mode bulk order will be lazy loaded after hitting the web app for the first time. Barcode scanner will be lazy loaded once the BulkOrder component is shown and opened from the header nav.
Our lighthouse score has increased by ~14 points and we are having initial pixel viewing times in ~4 seconds.
Here is a screenshot of performance from a netlify build in B2C mode:
Linting:
Tests:
e2e)Documentation: