Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added React.Fragment and element keys in App.tsx #700

Merged
merged 1 commit into from
May 11, 2020
Merged

Added React.Fragment and element keys in App.tsx #700

merged 1 commit into from
May 11, 2020

Conversation

dusanradovanovic
Copy link
Contributor

@dusanradovanovic dusanradovanovic commented May 11, 2020 •
edited
Loading

Description:

Replaced array with React.Fragment to App.tsx and reorganized Suspense elements to be inside ifs.

Linting:

  • No linting errors

Tests:

  • E2E tests (npm test run with e2e)
  • Manual tests
  • Accessibility tests (no new react-axe errors in console)

Documentation:

  • Requires documentation updates
  • Requires Storybook component updates

@shaunmaharaj shaunmaharaj merged commit 4b45ef3 into master May 11, 2020
@shaunmaharaj shaunmaharaj deleted the added-app-keys branch May 11, 2020 13:59
shaunmaharaj pushed a commit that referenced this pull request May 12, 2020
Fix tests from PR #700
31f858e 
- Fix tests from PR #700
@shaunmaharaj shaunmaharaj mentioned this pull request May 12, 2020
Merged
6 tasks
shaunmaharaj added a commit that referenced this pull request May 12, 2020
@shaunmaharaj
Fix tests from PR #700 (#704)
0d090e2 
- Fix tests from PR #700
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shaunmaharaj shaunmaharaj shaunmaharaj approved these changes

@aChanEP aChanEP Awaiting requested review from aChanEP

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dusanradovanovic @shaunmaharaj @dr-ep