Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RS-721 add quick view component #717

Merged
merged 4 commits into from
May 20, 2020
Merged

Conversation

yulia-dnistrian
Copy link
Contributor

@yulia-dnistrian yulia-dnistrian commented May 19, 2020

Description:

Linting:

  • No linting errors

Tests:

  • E2E tests (npm test run with e2e)
  • Manual tests
  • Accessibility tests (no new react-axe errors in console)

Documentation:

  • Requires documentation updates
  • Requires Storybook component updates

@BonnieEP
Copy link

BonnieEP commented May 19, 2020

@yulia-dnistrian the quick view looks good except for an issue with the sizing display.

When we have 4 or more sizes for an item, the 4th size drops down to the next line without enough line-spacing between the rows. Please add 12px or more line spacing between lines for sizes

Here is an example of the issue where the "x-large" size button is hitting the bottom of the large
Screen Shot 2020-05-19 at 11 51 45 AM

Please also re-order the sizes left to right to be "Small", "Medium", "Large" and "X-Large"

@shaunmaharaj shaunmaharaj merged commit a1a4e6a into master May 20, 2020
@shaunmaharaj shaunmaharaj deleted the RS-721-add-quick-view-component branch May 20, 2020 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants