Skip to content

Rs 721 add story for quick view #723

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 21, 2020
Merged

Rs 721 add story for quick view #723

merged 2 commits into from
May 21, 2020

Conversation

yulia-dnistrian
Copy link
Contributor

@yulia-dnistrian yulia-dnistrian commented May 21, 2020 •
edited
Loading

Description:

Linting:

  • No linting errors

Tests:

  • E2E tests (npm test run with e2e)
  • Manual tests
  • Accessibility tests (no new react-axe errors in console)

Documentation:

  • Requires documentation updates
  • Requires Storybook component updates

@yulia-dnistrian yulia-dnistrian self-assigned this May 21, 2020
@shaunmaharaj shaunmaharaj changed the title Rs 721 add story Rs 721 add story for quick view May 21, 2020
@shaunmaharaj shaunmaharaj merged commit 5431f72 into master May 21, 2020
@shaunmaharaj shaunmaharaj deleted the RS-721-add-story branch May 21, 2020 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shaunmaharaj shaunmaharaj shaunmaharaj approved these changes

Assignees

@yulia-dnistrian yulia-dnistrian

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yulia-dnistrian @shaunmaharaj