Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[1] Improve diff in dryrun script #382

Closed
pettersv opened this issue Apr 14, 2021 · 1 comment · Fixed by #431
Closed

[1] Improve diff in dryrun script #382

pettersv opened this issue Apr 14, 2021 · 1 comment · Fixed by #431
Assignees
@robinelastisys
Labels
good first issue Good for newcomers kind/improvement Improvement of existing features, e.g. code cleanup or optimizations. quick issue Small/quick issue to do while you are waiting or have little to do. Ok to pick from prio-backlog

Comments

@pettersv
Copy link
Contributor

pettersv commented Apr 14, 2021 •
edited
Loading

In the dryrun.sh script we currently use helmfile diff. This will not check agianst what the actual state of the cluster is. Change this to use helmfile template | kubectl diff instead.

In the apply.sh script, we should use helmfile sync instead of helmfile apply
@pettersv pettersv added good first issue Good for newcomers quick issue Small/quick issue to do while you are waiting or have little to do. Ok to pick from prio-backlog kind/improvement Improvement of existing features, e.g. code cleanup or optimizations. labels Apr 14, 2021
@viktor-f
Copy link
Contributor

See this issue for more context and inspiration: databus23/helm-diff#176

@tordsson tordsson changed the title Improve diff in dryrun script [1] Improve diff in dryrun script Apr 22, 2021
@robinelastisys robinelastisys self-assigned this May 4, 2021
@robinelastisys robinelastisys mentioned this issue May 5, 2021
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@robinelastisys robinelastisys

Labels
good first issue Good for newcomers kind/improvement Improvement of existing features, e.g. code cleanup or optimizations. quick issue Small/quick issue to do while you are waiting or have little to do. Ok to pick from prio-backlog
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

apps sc & wc: improve dry-run and deploy scripts elastisys/compliantkubernetes-apps
3 participants
@pettersv @viktor-f @robinelastisys