apps sc & wc: improve dry-run and deploy scripts #431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robinelastisys
force-pushed
the
Improve-dry-run-and-apply-scripts
branch
2 times, most recently
from
42e1130
to
1fdb78d
Compare
simonklb
requested changes
May 5, 2021
robinelastisys
force-pushed
the
Improve-dry-run-and-apply-scripts
branch
from
1fdb78d
to
1740d56
Compare
OlleLarsson
reviewed
May 6, 2021
robinelastisys
force-pushed
the
Improve-dry-run-and-apply-scripts
branch
2 times, most recently
from
003800c
to
dacf6f7
Compare
|
We had a meeting with the outcome: The changes could be activated by using a command flag |
robinelastisys
force-pushed
the
Improve-dry-run-and-apply-scripts
branch
2 times, most recently
from
193f254
to
34d6e2f
Compare
|
Now i have presented a start of a solution. Not the most beautiful but it works. "apply-sync" and "dry-run-sync". |
Xartos
requested changes
Jun 2, 2021
There was a problem hiding this comment.
Would it be possible to instead of introducing a new command, having a flag instread? Like
$ bin/ck8s apply --syncI guess something like getops would be something but that doesn't support long arguments (only single letter). If it's not feasable I'm okey with this approach as well.
I would also like to rename the dry-run-sync to dry-run-kubectl since it has nothing to do with sync.
There's also some formatting issues I have commented on
robinelastisys
force-pushed
the
Improve-dry-run-and-apply-scripts
branch
2 times, most recently
from
1a5bfc9
to
c1d537e
Compare
|
So, now i have done a lot of changes.
|
robinelastisys
force-pushed
the
Improve-dry-run-and-apply-scripts
branch
from
c1d537e
to
3d0e2f4
Compare
Xartos
requested changes
Jun 3, 2021
robinelastisys
force-pushed
the
Improve-dry-run-and-apply-scripts
branch
6 times, most recently
from
e2b5dc8
to
f21e149
Compare
robinelastisys
force-pushed
the
Improve-dry-run-and-apply-scripts
branch
from
f21e149
to
157b988
Compare
|
Done! Looks a lot smoother now indeed! 😄 👍 |
robinelastisys
force-pushed
the
Improve-dry-run-and-apply-scripts
branch
from
157b988
to
63e8cbd
Compare
Xartos
requested changes
Jun 10, 2021
robinelastisys
force-pushed
the
Improve-dry-run-and-apply-scripts
branch
from
63e8cbd
to
0945230
Compare
|
Done! 😄 |
Xartos
requested changes
Jun 10, 2021
simonklb
reviewed
Jun 10, 2021
robinelastisys
force-pushed
the
Improve-dry-run-and-apply-scripts
branch
from
0945230
to
614f212
Compare
viktor-f
reviewed
Jun 11, 2021
robinelastisys
force-pushed
the
Improve-dry-run-and-apply-scripts
branch
from
614f212
to
6d257c3
Compare
|
Please resolve some of the comments that's been fixed. A bit cumbersome to overview the pr ;) |
simonklb
requested changes
Jun 11, 2021
robinelastisys
force-pushed
the
Improve-dry-run-and-apply-scripts
branch
from
6d257c3
to
a182ce7
Compare
robinelastisys
force-pushed
the
Improve-dry-run-and-apply-scripts
branch
from
a182ce7
to
233757e
Compare
robinelastisys
force-pushed
the
Improve-dry-run-and-apply-scripts
branch
from
ec021a6
to
63039ac
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
The dry-run.sh and deploy scripts we currently use will not check against the actual state of the cluster. We are now adding commando flags to enable the option of using sync if a user want to.
Which issue this PR fixes
fixes #382
Message to reviewers
Im not sure if this is the right way to do it. This was the closest i could figure out. Feel free to point me out in the right direction if needed.
Checklist: