Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: user guide about graceful pod termination #956

Merged
merged 1 commit into from
Sep 13, 2024

Conversation

viktor-f
Copy link
Contributor

@viktor-f viktor-f commented Sep 5, 2024

⚠️ IMPORTANT ⚠️: This is a public repository. Make sure to not disclose:

  • personal data beyond what is necessary for interacting with this Pull Request;
  • business confidential information, such as customer names.

Quality gates:

  • I'm aware of the Contributor Guide and did my best to follow the guidelines.
  • I'm aware of the Glossary and did my best to use those terms.

Fixes #906

This writes about graceful termination of pods and how users can manage that.

@viktor-f viktor-f added the documentation Improvements or additions to documentation label Sep 5, 2024
@viktor-f viktor-f self-assigned this Sep 5, 2024
@viktor-f viktor-f requested a review from a team as a code owner September 5, 2024 13:01
Copy link
Contributor

@simonklb simonklb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some minor things + fix one sentence per line. Other than that, LGTM!

docs/user-guide/prepare-application.md Show resolved Hide resolved
docs/user-guide/prepare-application.md Outdated Show resolved Hide resolved
@viktor-f
Copy link
Contributor Author

viktor-f commented Sep 5, 2024

Updated now. But I'm not sure if we are trying to follow "one sentence per line" in this repo, since there are a lot of pages that does not do that. I changed it regardless since I agree that it is nice to have.

Copy link
Collaborator

@cristiklein cristiklein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice addition, thanks! Indeed, getting Pod termination right is something new when coming to the Kubernetes world.

I'd also like us to go for one-sentence-per-line. I know this is not consistent in this repo, but that's where we will slowly head to.

@viktor-f viktor-f merged commit 509c112 into main Sep 13, 2024
1 check passed
@viktor-f viktor-f deleted the vf/graceful-termination branch September 13, 2024 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mention graceful termination on the "Prepare Your Application" page
4 participants