Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

panics when cannot receive response #345

Closed
kubistika opened this issue Jun 12, 2019 · 0 comments
Closed

panics when cannot receive response #345

kubistika opened this issue Jun 12, 2019 · 0 comments

Comments

@kubistika
Copy link

To reproduce:

  1. Run the simple proxy example.
  2. Use wget to send it a request to a website that is down.

Don't see a reason to panic, why just don't call the DoHandler if the proxy failed to get a response?
kubistika added a commit to kubistika/goproxy that referenced this issue Jun 12, 2019
@kubistika
fixes elazarl#345: panic when resp == nil
3293ba8
@kubistika kubistika mentioned this issue Jun 12, 2019
Closed
elazarl pushed a commit that referenced this issue Jul 11, 2019
@elazarl
Issue: #345 - fixes resp == nil:
2719e7a 
* fixes the panic if the response is from a handler is nil
* adds test case for handler response is nil
tommysitu pushed a commit to SpectoLabs/goproxy that referenced this issue Jul 24, 2022
@tommysitu
Issue: elazarl#345 - fixes resp == nil:
6579977 
* fixes the panic if the response is from a handler is nil
* adds test case for handler response is nil
tommysitu pushed a commit to SpectoLabs/goproxy that referenced this issue Jul 24, 2022
@tommysitu
Fixes elazarl#345:
9bf55e7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kubistika