Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix]: Adding address inside the square brackets #563

Closed
wants to merge 1 commit into from

Conversation

nakul-py
Copy link

  • This PR fixes the issue where IPv6 addresses with ports were not being correctly parsed due to an incorrect handling of colons.
  • The fix ensures that the address is wrapped in square brackets and the port is properly separated.

- Fixes #562

@ErikPelli
Copy link
Collaborator

This is not the function that needs to be changed to fix the issue.
The problem is related to the request, in the reported issues linked in #562.
Here you are changing stripPort(), which is used only to extract the hostname for the certificate generation / cache retrieval.
If you find the correct solution, you can open another pull request. Closing this one.

@ErikPelli ErikPelli closed this Dec 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix ipv6 parsing
2 participants