Add a string concatenation to _read_body() #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I found that this fixes random breakage of results while selecting from a database. Fixes issue elcamlost#2 String concatenation may not be best solution for large selects because it builds large variable in memory (propose better solution if available).
|
Without this fix, it's impossible to use module with large responses. This changes definitely should be on CPAN |
|
More elegant solution is offered in this thread: |
Solution contributed by Corion at http://www.perlmonks.org/?node_id=1175544 This is low memory solution. Warning added in case that read_entity_body() returns an empty string but $remainder still has content. In my opinion this shouldn't happen, but at least we will see it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found that this fixes random breakage of results while selecting
from a database.
Fixes issue #2
String concatenation may not be best solution for large selects because
it builds large variable in memory (propose better solution if available).