Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify types for ESM module #135

Merged
merged 1 commit into from
Aug 2, 2023
Merged

Specify types for ESM module #135

merged 1 commit into from
Aug 2, 2023

Conversation

elchininet
Copy link
Owner

This pull request adds types to the exports definitions as recommended in the HandBook. This is to avoid TypeScript complaining about:

Could not find a declaration file for module 'colortranslator'. '/path-to-project/node_modules/colortranslator/esm/index.js' implicitly has an 'any' type.
  There are types at '/path-to-project/node_modules/colortranslator/index.d.ts', but this result could not be resolved when respecting package.json "exports". The 'colortranslator' library may need to update its package.json or typings.ts(7016)

@elchininet elchininet merged commit 916b58c into master Aug 2, 2023
@elchininet elchininet deleted the specify_types_for_esm branch August 2, 2023 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant