Sourcerer2: Moving to string based versions, introducing JDBC driver #22
Conversation
…g typing for versions and ids
|
|
||
| /** | ||
| * Throw to indicate that the current version of a stream does not match the expected one. | ||
| */ | ||
| public class UnexpectedVersionException extends IllegalStateException { | ||
| private final Integer currentVersion; | ||
| private final StreamVersion currentVersion; |
There was a problem hiding this comment.
|
|
||
| /** | ||
| * Throw to indicate that the current version of a stream does not match the expected one. | ||
| */ | ||
| public class UnexpectedVersionException extends IllegalStateException { | ||
| private final Integer currentVersion; | ||
| private final StreamVersion currentVersion; | ||
| private final ExpectedVersion expectedVersion; |
There was a problem hiding this comment.
| } | ||
|
|
||
| private fun serializeMetadata(metadata: Map<String, String>): String { | ||
| // TODO: Handle errors more nicely |
There was a problem hiding this comment.
| import org.reactivestreams.Publisher | ||
| import org.slf4j.LoggerFactory | ||
|
|
||
| internal class DbstoreEventRepository<T>( |
There was a problem hiding this comment.
| } | ||
|
|
||
| private fun serializeEvent(event: T): String { | ||
| // TODO: Handle errors more nicely |
There was a problem hiding this comment.
| } | ||
|
|
||
| private fun parseEvent(data: String): T { | ||
| // TODO: Handle errors more nicely |
There was a problem hiding this comment.
| } | ||
|
|
||
| private fun parseMetadata(metadata: String): ImmutableMap<String, String> { | ||
| // TODO: Handle errors more nicely |
There was a problem hiding this comment.
| streamId: StreamId, | ||
| category: String, | ||
| fromVersion: DbstoreStreamVersion? = null, | ||
| maxEvents: Int = 4096 |
There was a problem hiding this comment.
| category: String, | ||
| shard: Int?, | ||
| fromVersion: DbstoreRepositoryVersion? = null, | ||
| maxEvents: Int = 4096 |
There was a problem hiding this comment.
| return "ExpectedVersion.AnyExisting" | ||
| } | ||
| } | ||
| object Any : ExpectedVersion() { |
| + "' with 'not created'", | ||
| baseVersion, newVersion) | ||
| else -> | ||
| throw RuntimeException( |
There was a problem hiding this comment.
| ExpectedVersion.Any -> 0 | ||
| ExpectedVersion.AnyExisting -> 1 | ||
| is ExpectedVersion.Exactly -> 2 | ||
| ExpectedVersion.NotCreated -> 3 |
There was a problem hiding this comment.
| ExpectedVersion.NotCreated -> when (newVersion) { | ||
| ExpectedVersion.NotCreated -> baseVersion | ||
| else -> | ||
| throw RuntimeException( |
There was a problem hiding this comment.
| } else baseVersion ?: (newVersion ?: ExpectedVersion.any()) | ||
| } | ||
|
|
||
| /** |
There was a problem hiding this comment.
| return "ExpectedVersion.NotCreated" | ||
| } | ||
| } | ||
| object AnyExisting : ExpectedVersion() { |
| throw IllegalArgumentException("Version is not in expected format") | ||
| } | ||
|
|
||
| val timestampStr = version.substring(0, 24) |
There was a problem hiding this comment.
|
|
||
| sealed class EventSubscriptionUpdate<T> { | ||
| class CaughtUp<T> : EventSubscriptionUpdate<T>() | ||
| data class Event<T>(val event: EventRecord<T>): EventSubscriptionUpdate<T>() |
|
|
||
| import java.time.Instant; | ||
| import java.util.List; | ||
| import java.util.UUID; | ||
| import java.util.stream.IntStream; | ||
|
|
||
| import static org.mockito.Matchers.any; | ||
| import static org.mockito.Mockito.mock; | ||
| import static org.mockito.Mockito.when; | ||
|
|
||
| public class EventSubscriptionManagerTest { |
|
SonarQube analysis reported 52 issues
Watch the comments in this conversation to review them. 7 extra issuesNote: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:
|
That way we know it doesn't blow up when it doesn't exist.
To make the options explicit.
Allow for noop:ing a create if aggregate already exists
Prepare for adding retry-support.
If an update was made to the aggregate after it was read but before it was updated, retry (according to policy).
Don't say "current version null" when current version is unknown, as it looks like current version is notExisting. Keep UnexpectedVersionException in stack trace for AtomicWriteException.
Instead use RetryHandler and RetryPolicy directly.
Don't add variance.
Add support for retrying atomic write failures
Which supports preferRandomNode
Update esjc dependency to 1.8.1
…default timeout to 1000ms
…store-health-probe Prometheus monitoring for EventStore health probe
Upgrading to ESJC 2.x (with 64 bit positions)
This change is