Improve tests for cache drivers (#64)

elecena · Sep 1, 2021 · 394381a · 394381a
1 parent c8ba1e5
commit 394381a
Show file tree

Hide file tree

Showing 4 changed files with 52 additions and 37 deletions.
diff --git a/tests/CacheCoreTest.php b/tests/CacheCoreTest.php
diff --git a/tests/CacheFileTest.php b/tests/CacheFileTest.php
@@ -1,12 +1,14 @@
 <?php
 
+use Nano\Cache;
+
 /**
  * Set of unit tests for Cache file driver
  */
 
 class CacheFileTest extends CacheTest
 {
-    protected function getCacheInstance($settings = [])
+    protected function getCacheInstance(array $settings = []): Cache
     {
         $dir = dirname(__FILE__) . '/app/cache';
 

diff --git a/tests/CacheRedisTest.php b/tests/CacheRedisTest.php
@@ -1,5 +1,7 @@
 <?php
 
+use Nano\Cache;
+
 /**
  * Set of unit tests for Cache redis driver
  *
@@ -10,9 +12,10 @@ class CacheRedisTest extends CacheTest
 
     /**
      * @param array $settings
-     * @return \Nano\Cache
+     * @return Cache
+     * @throws Exception
      */
-    protected function getCacheInstance($settings = [])
+    protected function getCacheInstance(array $settings = []): Cache
     {
         $settings = array_merge([
             'host' => '127.0.0.1',
@@ -21,4 +24,19 @@ protected function getCacheInstance($settings = [])
 
         return $this->getCache('redis', $settings);
     }
+
+    /**
+     * @throws Exception
+     */
+    public function testSetCacheInfinity()
+    {
+        $cache = $this->getCacheInstance();
+
+        $key = 'foo';
+        $value = 'bar';
+
+        $this->assertTrue($cache->set($key, $value));
+        $this->assertTrue($cache->exists($key));
+        $this->assertEquals($value, $cache->get($key));
+    }
 }
diff --git a/tests/CacheTest.php b/tests/CacheTest.php
@@ -1,13 +1,17 @@
 <?php
 
 use Nano\Cache;
+use Nano\NanoBaseTest;
 
 /**
  * Generic class for unit tests for Cache drivers
  */
-abstract class CacheTest extends \Nano\NanoBaseTest
+abstract class CacheTest extends NanoBaseTest
 {
-    protected function getCache($driver, array $settings = [])
+    /**
+     * @throws Exception
+     */
+    protected function getCache($driver, array $settings = []): Cache
     {
         // use test application's directory
         $dir = realpath(dirname(__FILE__) . '/app');
@@ -21,11 +25,29 @@ protected function getCache($driver, array $settings = [])
         return Cache::factory($settings);
     }
 
-    public function testCacheFactory()
+    /**
+     * @param string $cacheDriver
+     * @param array $cacheOptions
+     * @param string $expectedClass
+     * @dataProvider cacheFactoryProvider
+     * @throws Exception
+     */
+    public function testCacheFactory(string $cacheDriver, array $cacheOptions, string $expectedClass)
     {
-        $this->assertInstanceOf('Nano\Cache\CacheFile', $this->getCache('file'));
-        $this->assertInstanceOf('Nano\Cache\CacheFile', $this->getCache('File'));
-        $this->assertInstanceOf('Nano\Cache\CacheRedis', $this->getCache('redis', ['host' => '127.0.0.1']));
+        $this->assertInstanceOf($expectedClass, $this->getCache($cacheDriver, $cacheOptions));
+    }
+
+    public function cacheFactoryProvider(): Generator
+    {
+        yield 'file' => [
+            'file', [], Cache\CacheFile::class
+        ];
+        yield 'File' => [
+            'File', [], Cache\CacheFile::class
+        ];
+        yield 'redis' => [
+            'redis', ['host' => '127.0.0.1'], Cache\CacheRedis::class
+        ];
     }
 
     /**
@@ -34,14 +56,11 @@ public function testCacheFactory()
      * @param array $settings
      * @return Cache
      */
-    abstract protected function getCacheInstance($settings = []);
+    abstract protected function getCacheInstance(array $settings = []): Cache;
 
     public function testCacheGetSet()
     {
         $cache = $this->getCacheInstance();
-        if ($cache === false) {
-            return;
-        }
 
         $key = 'foo';
         $value = [
@@ -82,9 +101,6 @@ public function testCacheGetSet()
     public function testCacheIncrDecr()
     {
         $cache = $this->getCacheInstance();
-        if ($cache === false) {
-            return;
-        }
 
         $key = 'bar';
         $value = 12;
@@ -114,10 +130,6 @@ public function testCachePrefix()
         $cacheA = $this->getCacheInstance();
         $cacheB = $this->getCacheInstance(['prefix' => 'foo']);
 
-        if ($cacheA === false) {
-            return;
-        }
-
         $key = 'bar';
         $value = 12;