Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run phpunit as a part of CI pipeline #1

Merged
merged 8 commits into from
Mar 15, 2021
Merged

Run phpunit as a part of CI pipeline #1

merged 8 commits into from
Mar 15, 2021

Conversation

macbre
Copy link
Member

@macbre macbre commented Mar 15, 2021

No description provided.

@macbre
Copy link
Member Author

macbre commented Mar 15, 2021

PHP 7.4:

There was 1 error:

1) StaticAssetsTest::testServeTypeCheck
"continue" targeting switch is equivalent to "break". Did you mean to use "continue 2"?

/home/runner/work/nano/nano/vendor/tedivm/jshrink/src/JShrink/Minifier.php:234
/home/runner/work/nano/nano/classes/staticassets/StaticAssetsJs.class.php:28
/home/runner/work/nano/nano/classes/StaticAssetsProcessor.class.php:57
/home/runner/work/nano/nano/classes/StaticAssets.class.php:435
/home/runner/work/nano/nano/classes/StaticAssets.class.php:383
/home/runner/work/nano/nano/tests/StaticAssetsTest.php:95

@macbre macbre marked this pull request as ready for review March 15, 2021 15:09
@macbre macbre merged commit 6a15d34 into master Mar 15, 2021
@macbre macbre deleted the phpunit-in-ci branch March 15, 2021 15:09
macbre added a commit that referenced this pull request Sep 22, 2022
Production (when switched to PHP 8.1) reports:

[22-Sep-2022 15:33:25 Europe/Berlin] PHP Deprecated:  trim(): Passing null to parameter #1 ($string) of type string is deprecated in /usr/home/macbre/elecena/git/app/vendor/elecena/nano/classes/Router.class.php on line 286
[22-Sep-2022 15:33:25 Europe/Berlin] PHP Deprecated:  Return type of DatabaseResult::current() should either be compatible with Iterator::current(): mixed, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in /usr/home/macbre/elecena/git/app/vendor/elecena/nano/classes/DatabaseResult.class.php on line 101
macbre added a commit that referenced this pull request Sep 22, 2022
Fixes:

 PHP Deprecated:  trim(): Passing null to parameter #1 ($string) of type string is deprecated in /usr/home/macbre/elecena/git/app/vendor/elecena/nano/classes/Router.class.php on line 286
macbre added a commit that referenced this pull request Nov 3, 2022
Router - fix passing null to parameter #1 ($string) of type string is deprecated
macbre added a commit that referenced this pull request May 22, 2023
…_put_contents() calls

TypeError: count(): Argument #1 ($value) must be of type Countable|array, null given
/Users/macbre/git/elecena/nano/classes/utils/SitemapGenerator.class.php:189
/Users/macbre/git/elecena/nano/classes/utils/SitemapGenerator.class.php:207
/Users/macbre/git/elecena/nano/tests/SitemapGeneratorTest.php:16
macbre added a commit that referenced this pull request May 22, 2023
Fixes: TypeError: count(): Argument #1 ($value) must be of type Countable|array, null given
macbre added a commit that referenced this pull request Aug 9, 2023
And add some tests coverage.

Fixes: TypeError: Nano\Logger\NanoLogger::Nano\Logger\{closure}(): Argument #1 ($record) must be of type array, Monolog\LogRecord given, called in Monolog/Logger.php on line 366
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant