Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require PHP 8.2+ #441

Merged
merged 5 commits into from
Dec 13, 2024
Merged

Require PHP 8.2+ #441

merged 5 commits into from
Dec 13, 2024

Conversation

macbre
Copy link
Member

@macbre macbre commented Dec 13, 2024

No description provided.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
macbre and others added 2 commits December 13, 2024 13:56

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@macbre
Copy link
Member Author

macbre commented Dec 13, 2024

Error: Deprecated in PHP 8.4: Parameter #2 $onQuery (callable) is implicitly nullable via default value null.
Error: Deprecated in PHP 8.4: Parameter #1 $callback (callable) is implicitly nullable via default value null.
 ------ ----------------------------------------------------------------------- 
  Line   classes/NanoBaseTest.class.php                                         
 ------ ----------------------------------------------------------------------- 
  36     Deprecated in PHP 8.4: Parameter #2 $onQuery (callable) is implicitly  
         nullable via default value null.                                       
         🪪  parameter.implicitlyNullable                                       
 ------ ----------------------------------------------------------------------- 

 ------ ------------------------------------------------------------- 
  Line   classes/NanoDatabaseMock.class.php                           
 ------ ------------------------------------------------------------- 
  28     Deprecated in PHP 8.4: Parameter #1 $callback (callable) is  
         implicitly nullable via default value null.                  
         🪪  parameter.implicitlyNullable                             
 ------ ------------------------------------------------------------- 

Error:  [ERROR] Found 2 errors                                                         

@macbre macbre marked this pull request as ready for review December 13, 2024 14:06
@macbre macbre merged commit 1e60667 into master Dec 13, 2024
7 checks passed
@macbre macbre deleted the php/8.2 branch December 13, 2024 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant