Added warning if Imagick is not installed/enabled. #590
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If GD is used instead of Imagick, rotating uploaded pictures leads to a loss of their metadata. Since this is unexpected and maybe a problem, the diagnostics should show a warning. This commit displays a warning if it's either not installed or not enabled in settings.
|
Fantastic idea! Thanks. |
Showing a warning should be enough. Complaints are relative low. It seems like most users want their photos rotated correctly rather than keeping the metadata. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If GD is used instead of Imagick, rotating uploaded pictures leads to
a loss of their metadata. Since this is unexpected and maybe a problem,
the diagnostics should show a warning.
This commit displays a warning if it's either not installed or not
enabled in settings.
Maybe, rotating pictures etc. should even be optional in case the user
can't install imagick and still doesn't want to lose the metadata?