-
-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fs/jquinn #41
Open
fsargent
wants to merge
162
commits into
main
Choose a base branch
from
fs/jquinn
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added low information strategies and Minimax
Wrote some of threeRoundResults, added a basic but non-rigorous pollsToProbs function, refactored low-information strats, and added a better zero-information approval voting strategy.
Switched to using threeRoundResult. Removed @rememberBallot decorators. Switched from static methods to class methods for strategy functions and results.
Bug fix
Implemented the binary search for determining the minimum foreground to elect the winner under strategy and ensured that all results are returned.
Added comp and diehard strategies for plurality, approval, score, and IRV. (Not yet added for STAR or Condorcet.)
Added diehard and compromise strategies for STAR and Condorcet. Improved the low info strategies for top2 methods. Increased the default polling uncertainty.
It's slow.
created tieFor2Estimate
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Quite a few exceptions, if you can work on these, @homunq and @ragconsumer. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.