chore(sync-service): Set display settings before querying initial data

[alco]

Follow-up to #220.

[robacourt]

Looks good!

You asked about tests - how about a test for query_in_readonly_txn specifically that actually hits the db in the shape_cache tests? Seems that could do with some tests anyway since it's normally mocked out. There's no module wide setup in the shape_cache tests so a new describe block which uses the TransactionCase should do it, right?

[robacourt]

Looks good!

You asked about tests - how about a test for query_in_readonly_txn specifically that actually hits the db in the shape_cache tests? Seems that could do with some tests anyway since it's normally mocked out. There's no module wide setup in the shape_cache tests so a new describe block which uses the TransactionCase should do it, right?

Or another option is that query_in_readonly_txn is extracted to another module and tested separately.

[alco]

@robacourt Thanks for the suggestions!

I hadn't noticed initially that ShapeCacheTest already had some tests running against a real database. I've added another one there to verify correct formatting for snapshot data.

Really wanted to avoid testing query_in_readonly_txn directly because that's an implementation detail. Ideally, we would test the response payload returned by ServerShapePlug. But testing ShapeCache is good enough for now.