chore: Refactor ReplicationClient into a state machine #247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alco
changed the title
icehaunter
approved these changes
Aug 5, 2024
robacourt
approved these changes
Aug 5, 2024
alco
force-pushed
the
alco/replication-client-refactor
branch
from
6cb0c2b to
f5e66d0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seeing how the setup code in
Electric.Postgres.ReplicationClienthas been getting more complicated, I've made an attempt to refactor it into a separate module to make it clear which query follows which before the connection is switched into the logical streaming mode.In the end I have to say, that the amount of boilerplate has exceed my expectations, not in a good way. Still, I would like another person's opinion on whether this change makes it easier to reason about the replication client and its two operating modes: 1) connection setup and 2) logical streaming.
Ideally, I would have loved to use e.g.
epgsqlfor the connection setup, then pass the connection socket over toPostgrex.ReplicationConnectionfor streaming. That would have made the code much simpler.