Fix binary string issue #10
Conversation
|
How do I see what's failing in the tests? |
you can view the test status at https://cse-ci.electricimp.com, log-in as a guest, click on the project and look for the build log for the pull request that is failing. |
|
@betzrhodes I've come back to this -- left it too long, really -- and fixed the breaking tests. I'd forgotten to update them for the new way (correct as per JSON spec.) of doing blobs. As a result, I've bumped this update to 3.0.0 since it's a breaking change. This could therefore do with a review, when you get a moment. |
README.md
Outdated
|
|
||
| This library can be used to encode Squirrel data structures into JSON. | ||
|
|
||
| **To add this library to your project, add** `#require "JSONEncoder.class.nut:2.0.0"` **to the top of your code.** | ||
| **To include this library in your project, add** `#require "JSONEncoder.class.nut:2.0.1"` **at the top of your code.** |
|
Something to think about. This update leaves our JSON libraries out of sync with each other - If I encode a blob with the encoder and then parse it with the parser I will not get the result I would expect: jsonString <- JSONEncoder.encode(b); server.log(crypto.equals(result, b)); While this approach mitigates the errors I'm not sure this is the best direction for the library to head in. |
| @@ -1,23 +1,23 @@ | |||
| #require "JSONEncoder.class.nut:1.0.0" | |||
| #require "JSONEncoder.class.nut:3.0.0" | |||
examples/example-e.nut
Outdated
| local uniStr1 = "💾❤️😎🎸"; | ||
| local uniStr2 = "\xF0\x9F\x98\x9C"; | ||
|
|
||
| local j = JSONEncoder.encode({"binary_data":b, "uni_strings": [{"uni_string_one":uniStr}, {"uni_string_two":uniStr2}]}); |
There was a problem hiding this comment.
typo - ERROR: the index 'uniStr' does not exist
JSONEncoder.class.nut
Outdated
| local ch2 = (str[++i] & 0xFF); | ||
| res += format("%c%c", ch1, ch2); | ||
| } else { | ||
| //throw "Insufficient data for 2-byte Unicode"; |
JSONEncoder.class.nut
Outdated
| local ch3 = (str[++i] & 0xFF); | ||
| res += format("%c%c%c", ch1, ch2, ch3); | ||
| } else { | ||
| //throw "Insufficient data for 3-byte Unicode"; |
JSONEncoder.class.nut
Outdated
| local ch4 = (str[++i] & 0xFF); | ||
| res += format("%c%c%c%c", ch1, ch2, ch3, ch4); | ||
| } else { | ||
| //throw "Insufficient data for 4-byte Unicode"; |
See https://electricimp.atlassian.net/browse/CSE-702
Convert blob values to base64 strings