-
Notifications
You must be signed in to change notification settings - Fork 963
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create parser for new data source for Puerto Rico #5232
base: master
Are you sure you want to change the base?
Create parser for new data source for Puerto Rico #5232
Conversation
1998b2b
to
13c6559
Compare
13c6559
to
1c2f88c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general this looks good and everything is working but there are some small things that need changing.
I can take a look a that this week if you don't have the time.
I also noticed the:
# TODO add forecast parser
# print('fetch_generation_forecast() ->')
# print(fetch_generation_forecast())
I'm not sure if this was the plan all along but I think it makes sense to implement that in a separate PR so we can get this merged as fast as possible.
That's actually carried over over from the old parser. I left it in because the new data source also has a forecast for the present day. |
I've found a source for power plant fuel that lists the fuel type by power plant, but it again differs from what I've found so far (doesn't mention the 'dual fuel' for Costa Sur and just lists them as 'natural gas'); however, this one is very recent (2022). (Another difference: it has two of the units of another plant as 'diesel/natural gas'.) https://energia.pr.gov/wp-content/uploads/sites/7/2022/09/Motion-to-Submit-Lumas-Resource-Adequacy-Study-NEPR-MI-2022-0002.pdf (page 35 in the PDF, although the number in the document itself says "28".) Should I use this one, then? (Feel free to update my parser if you want to.) |
We usually use the latest information so I'd use the new one. I'm not sure how we should do about the other plants though, where they previously only diesel or only natural gas? If so I'd say put them in unknown and we can try and find a good estimation of the emission factor instead. |
Hi again @q--, sorry for not getting around to this earlier. But I think you can use the source you provided for the plant mappings but I would map the dual fuel ones to unknown, at least for now. Let me know if there is anything you need from my side or if you want someone else to take over this PR. |
Hi, If someone else want to take care of the finishing touch, I'm okay with that. I might have some time to work on this later this week, but TBF it doesn't have the highest priority to me so I can't promise I actually will do so. |
All good! I'll take a look at it if I got the time. |
Looking at the EIA capacity report shared in #5662 I see that Costa Sur has 6 generators 4 of which is listed as Petroleum Liquids and 2 as Natural Gas Steam Turbine. It might be best to add this to unknown and create a override for the unknown emission factor instead of attributing it to a defined mode? |
I'd like to also point out that the EIA webpage has also information regarding the production of each plant by fuel type. It should be useful to calculate the percentages for the unknown. (I've hidden some columns for clarity) |
Any updates on this? otherwise we might close it due to staleness |
Looking at the spreadsheet linked by @silimotion, this contains the information we need to map some plants to oil, others to gas and determine the ratio (and therefore carbon intensity override) for those that burn both. It's mostly a matter of actually doing the work, which in summary boils down to:
Now, I'm not actually expecting I'll work on this soon... But if someone comments a code |
Side note: it also seems that there's a bit of new generation listed at https://aeepr.com/#/operacion, that would be needed to be added as well |
Great! Thanks for the details :) |
Implements the new data source for Puerto Rico.
Closes #3999
Note: I'm not 100% sure about the fuel mapping; for example, I found out just before committing that one of the plants (see the comment in the source code) that I found elsewhere was running on fuel oil has actually been dual-fuel for some years, also accepting natural gas as a fuel. (So perhaps this should be changed to 'unknown'?) But I don't have time to work on this anymore today and I'm not sure when I'll work on this again, so if anyone else wants to look into this, please do.
Note 2:
unknown
used to be renewable in the old parser. It no longer is in the new parser. Some configuration might have to be changed to reflect this.