Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iOS header overlaps with UI #6966 (Fixed) #7294

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Xeno-Tek
Copy link

@Xeno-Tek Xeno-Tek commented Oct 8, 2024

iOS header overlaps with UI (Fixed):

fix: resolve iOS header overlap by adding safe area insets to CSS


Issue:

Closes #6966


Description:

This PR resolves the issue where the iOS header (time, date, battery, etc.) overlaps with the UI when the app is viewed on iPads. The problem stems from the layout not considering the iOS-specific safe area insets.

  • Added CSS safe area insets (env(safe-area-inset-*)) to ensure proper padding for iOS devices.
  • Adjusted padding-top, padding-bottom, and side insets for better alignment and to prevent header overlap.
  • Maintained the integrity of existing styles while applying the necessary layout fixes.

Preview:

Please find below a screenshot demonstrating the resolution of the issue:

373942909-946e6ccf-916e-4ad6-96c6-3c046f8de167

Double Check:

  • I have tested my changes on an iOS device (iPad).
  • I have verified that the safe area insets do not affect non-iOS devices.

fix: resolve iOS header overlap by adding safe area insets to CSS

- Added safe area insets to ensure proper padding for iOS devices
- Applied padding-top, padding-bottom, and side insets for better UI alignment
- Ensured header and layout are no longer blocked by system elements
@Xeno-Tek Xeno-Tek marked this pull request as draft October 8, 2024 00:22
@Xeno-Tek Xeno-Tek marked this pull request as ready for review October 8, 2024 00:23
@VIKTORVAV99 VIKTORVAV99 self-requested a review October 8, 2024 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

iOS header overlaps with UI
1 participant