Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tamil Language for zones & slider #7533

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Tamil Language for zones & slider #7533

wants to merge 1 commit into from

Conversation

Nivedhitha-dp
Copy link

@Nivedhitha-dp Nivedhitha-dp commented Dec 10, 2024 •
edited
Loading

Issue

Description

Preview

Double check

  • I have tested my parser changes locally with poetry run test_parser "zone_key"
  • I have run pnpx prettier@2 --write . and poetry run format in the top level directory to format my changes.

@Nivedhitha-dp Nivedhitha-dp requested a review from a team as a code owner December 10, 2024 02:39
VIKTORVAV99
VIKTORVAV99 requested changes Dec 10, 2024
View reviewed changes
Copy link
Member

@VIKTORVAV99 VIKTORVAV99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR but you can not add non english translations to the english translation file.

Furthermore this contain unrelated changes in the bar breakdown chart.

@VIKTORVAV99 VIKTORVAV99 marked this pull request as draft December 10, 2024 15:21
@VIKTORVAV99 VIKTORVAV99 removed the request for review from a team December 10, 2024 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VIKTORVAV99 VIKTORVAV99 VIKTORVAV99 requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
translations 🗣
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Nivedhitha-dp @VIKTORVAV99