Merged GB and GB-ZET in world.geojson #7583
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VIKTORVAV99
requested changes
Dec 20, 2024
There was a problem hiding this comment.
Unfortunately it's not as simple as just merging the two zones in the world file.
We also need to clean up the config files and move it to the retired zones.
Once that has been done I can take it over from there as we also need to do some adjustments in the API when we remove a zone to ensure API calls don't fail and match what is done on the app.
Either way, thanks for opening the PR!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Closes #7269
Closes #7121
Description
Merged the world map polygon and properties for GB-ZET into GB as per the discussion in the two linked issues, the connection between the two is now in full effect as per (https://www.ssen-transmission.co.uk/projects/project-map/shetland/) and the Viking windfarm reports to Elexon as previously discussed.
Preview
Double check
pnpx prettier@2 --write .andpoetry run formatin the top level directory to format my changes.