perf: reduce min / max loops #7607
Open
+39
−56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
Comment on lines
-47
to
+52
| const datetime = new Date(datetimeString); | ||
| const { value: price } = convertPrice(value.price?.value, value.price?.currency); | ||
|
|
||
| chartData.push({ | ||
| datetime, | ||
| const chartData = Object.entries(zoneData.zoneStates).map( | ||
| ([datetimeString, value]) => ({ | ||
| datetime: new Date(datetimeString), | ||
| layerData: { | ||
| price: price ?? Number.NaN, | ||
| price: | ||
| convertPrice(value.price?.value, value.price?.currency).value ?? Number.NaN, | ||
| }, | ||
| meta: value, | ||
| }); | ||
| } | ||
| }) | ||
| ); |
There was a problem hiding this comment.
Doesn't this change the output from price: 123 to price: { value: 123 }? 🤔
There was a problem hiding this comment.
I'll have to double check again, was a while ago I wrote it but the charts work just fine in the preview.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
We are mapping over some objects twice to calculate the min, and then once again for the max value.
We can simplify this to one loop/map and then pass the mapped values to both functions.
Description
Reduces the looping and uses more functional syntax.
Double check
pnpx prettier@2 --write .andpoetry run formatin the top level directory to format my changes.