Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(parsers, ES-IB-ME): add capacity config #7708

Merged
merged 2 commits into from
Jan 23, 2025

Conversation

consideRatio
Copy link
Contributor

@consideRatio consideRatio commented Jan 8, 2025

Issue

Description

@hectodium had done an great writeup about the capacities for ES-IB-ME, so I just did the simple task of adding capacity config based on @hectodium's summary.

With this, I also add @hectodium under the contributors config for ES-IB-ME!

Double check

  • I have run pnpx prettier@2 --write . and poetry run format in the top level directory to format my changes.

@github-actions github-actions bot added the zone config Pull request or issue for zone configurations label Jan 8, 2025
@consideRatio
Copy link
Contributor Author

Should the zone config sources be updated as well to reflect what was used to determine this, or are those sources scoped to automatically fetched data?

@VIKTORVAV99
Copy link
Member

VIKTORVAV99 commented Jan 8, 2025

Should the zone config sources be updated as well to reflect what was used to determine this, or are those sources scoped to automatically fetched data?

Right now I think the sources only apply to the carbon intensity sources.
We have an updated format with versioned capacities (by datetime) and those contain their own capacity source which is then automatically extracted.

They look like this (for DK-DK2):

capacity:
  biomass:
    - datetime: '2017-01-01'
      source: entsoe.eu
      value: 234.0
    - datetime: '2018-01-01'
      source: entsoe.eu
      value: 1173.0
    - datetime: '2019-01-01'
      source: entsoe.eu
      value: 1202.0
    - datetime: '2020-01-01'
      source: entsoe.eu
      value: 1351.0
    - datetime: '2021-01-01'
      source: entsoe.eu
      value: 1350.0
    - datetime: '2022-01-01'
      source: entsoe.eu
      value: 1352.0
    - datetime: '2023-01-01'
      source: entsoe.eu
      value: 1237.0
  coal:
    - datetime: '2017-01-01'
      source: entsoe.eu
      value: 2072.0
    - datetime: '2018-01-01'
      source: entsoe.eu
      value: 1741.0
    - datetime: '2021-01-01'
      source: entsoe.eu
      value: 1471.0
    - datetime: '2022-01-01'
      source: entsoe.eu
      value: 1222.0
    - datetime: '2023-01-01'
      source: entsoe.eu
      value: 1079.0
  gas:
    - datetime: '2017-01-01'
      source: entsoe.eu
      value: 1241.0
    - datetime: '2018-01-01'
      source: entsoe.eu
      value: 665.0
    - datetime: '2019-01-01'
      source: entsoe.eu
      value: 663.0
    - datetime: '2020-01-01'
      source: entsoe.eu
      value: 620.0
    - datetime: '2021-01-01'
      source: entsoe.eu
      value: 605.0
    - datetime: '2022-01-01'
      source: entsoe.eu
      value: 603.0
    - datetime: '2023-01-01'
      source: entsoe.eu
      value: 577.0
  hydro:
    - datetime: '2017-01-01'
      source: entsoe.eu
      value: 0.0
  oil:
    - datetime: '2017-01-01'
      source: entsoe.eu
      value: 759.0
    - datetime: '2018-01-01'
      source: entsoe.eu
      value: 799.0
    - datetime: '2022-01-01'
      source: entsoe.eu
      value: 801.0
    - datetime: '2023-01-01'
      source: entsoe.eu
      value: 764.0
  solar:
    - datetime: '2017-01-01'
      source: entsoe.eu
      value: 180.0
    - datetime: '2018-01-01'
      source: entsoe.eu
      value: 338.0
    - datetime: '2019-01-01'
      source: entsoe.eu
      value: 342.0
    - datetime: '2020-01-01'
      source: entsoe.eu
      value: 341.0
    - datetime: '2021-01-01'
      source: entsoe.eu
      value: 422.0
    - datetime: '2022-01-01'
      source: entsoe.eu
      value: 450.0
    - datetime: '2023-01-01'
      source: entsoe.eu
      value: 620.0
    - datetime: '2024-01-01'
      source: entsoe.eu
      value: 992.0
  unknown:
    - datetime: '2017-01-01'
      source: entsoe.eu
      value: 13.0
    - datetime: '2018-01-01'
      source: entsoe.eu
      value: 21.0
    - datetime: '2019-01-01'
      source: entsoe.eu
      value: 24.0
    - datetime: '2020-01-01'
      source: entsoe.eu
      value: 25.0
  wind:
    - datetime: '2017-01-01'
      source: entsoe.eu
      value: 1036.0
    - datetime: '2018-01-01'
      source: entsoe.eu
      value: 1182.0
    - datetime: '2019-01-01'
      source: entsoe.eu
      value: 1180.0
    - datetime: '2021-01-01'
      source: entsoe.eu
      value: 1179.0
    - datetime: '2022-01-01'
      source: entsoe.eu
      value: 1784.0
    - datetime: '2024-01-01'
      source: entsoe.eu
      value: 1793.0

The format of these are optimized so each datetime is valid until the next so if there is a duplicate value for two or more years in a row only the first year needs to be added.

Note that it's not a requirement to add this, both types are supported for the time being but the first one don't have any capacity sources and are not versioned so we don't have a history of the capacity (this is used for outlier detection for now).

@consideRatio
Copy link
Contributor Author

Ah, I'll do a pass and update to the new format tomorrow! Thanks for the quick review turnaround once again @VIKTORVAV99!

@VIKTORVAV99
Copy link
Member

Ah, I'll do a pass and update to the new format tomorrow! Thanks for the quick review turnaround once again @VIKTORVAV99!

Thank you for all the issues you have resolved! 💚

@consideRatio
Copy link
Contributor Author

consideRatio commented Jan 9, 2025

Rebased and added 53fe587, using the richer capacity format, adding sources and dates. I added historical entries for wind and solar as well, as their values changed over time as discussed by @hectodium.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

@consideRatio
Copy link
Contributor Author

Force pushed a rebase on master.

Copy link
Member

@VIKTORVAV99 VIKTORVAV99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🎉

@VIKTORVAV99 VIKTORVAV99 merged commit fe58d7b into electricitymaps:master Jan 23, 2025
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
zone config Pull request or issue for zone configurations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add installed capacities for Menorca (ES-IB-ME)
2 participants