Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RTTI should also be disabled on the core Makefile #503

Closed
ifranco opened this issue Mar 23, 2022 · 1 comment · Fixed by #516
Closed

RTTI should also be disabled on the core Makefile #503

ifranco opened this issue Mar 23, 2022 · 1 comment · Fixed by #516

Comments

@ifranco
Copy link
Contributor

ifranco commented Mar 23, 2022

RTTI should be disabled on the core Makefile:

CPPFLAGS += \
-fno-exceptions \
-fasm \
-finline \
-finline-functions-called-once \
-fshort-enums \
-fno-move-loop-invariants \
-fno-unwind-tables \
-fno-rtti \
-Wno-register

Discovered when trying to override virtual functions on a user program.
@ifranco
Copy link
Contributor Author

ifranco commented Apr 19, 2022

I just wanted to add that this is a significant issue since the UI system depends heavily on overriding.

stephenhensley pushed a commit that referenced this issue Apr 28, 2022
fixed #503 - added norrti flag to core/Makefile
3a0282e
@stephenhensley stephenhensley mentioned this issue Apr 28, 2022
Merged
stephenhensley added a commit that referenced this issue Apr 28, 2022
@stephenhensley
fixed #503 - added norrti flag to core/Makefile (#516)
7950ba9 
Co-authored-by: stephenhensley <stephen.p.hensley@gmail.com>
@ghoppla ghoppla mentioned this issue Nov 29, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added nortti to core/Makefile electro-smith/libDaisy
1 participant
@ifranco