Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Use GITHUB_OUTPUT envvar instead of set-output command #1903

Merged
merged 1 commit into from
Jul 1, 2024

Conversation

arunsathiya
Copy link
Contributor

save-state and set-output commands used in GitHub Actions are deprecated and GitHub recommends using environment files.

This PR updates the usage of set-output to $GITHUB_OUTPUT

Instructions for envvar usage from GitHub docs:

https://docs.github.com/en/actions/using-workflows/workflow-commands-for-github-actions#setting-an-output-parameter

@CLAassistant
Copy link

CLAassistant commented Dec 30, 2023

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@friederbluemle friederbluemle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @arunsathiya 👍

Just one small update: I removed the commit Quote envvar to match documentation again - It is correct some documentation sources include the quotes, but they don't appear to be required. The official blog post has a sample with the non-quoted variable:


image

@friederbluemle
Copy link
Member

We'll address the failing Azure CI (unrelated to this PR) separately. Thanks @arunsathiya!

@friederbluemle friederbluemle merged commit 6b47a68 into electrode-io:master Jul 1, 2024
8 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants