Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade ERN to support RN 0.72 #1906

Merged
merged 4 commits into from
Jul 26, 2024
Merged

Conversation

rthic23
Copy link
Contributor

@rthic23 rthic23 commented Jun 12, 2024

ANDROID

  • Update Android Plugins/ tools and templates to support RN 0.72.x - https://github.com/electrode-io/react-native/tree/0.72-stable/packages/react-native/template/android
    DEFAULT_RN_GRADLE_PLUGIN_VERSION = '0.72.11';
    ANDROID_GRADLE_PLUGIN_VERSION = '7.4.2';
    ANDROIDX_APPCOMPACT_VERSION = '1.1.0';
    ANDROIDX_LIFECYCLE_EXTENSIONS_VERSION = '2.1.0';
    BUILD_TOOLS_VERSION = '33.0.0';
    COMPILE_SDK_VERSION = '33';
    GRADLE_DISTRIBUTION_VERSION = '8.0.1';
    JSC_VARIANT = 'android-jsc';
    KOTLIN_VERSION = '1.7.22';
    MIN_SDK_VERSION_PRE_RN64 = '19';
    MIN_SDK_VERSION_POST_RN64 = '21';
    SUPPORT_LIBRARY_VERSION = '28.0.0';
    TARGET_SDK_VERSION = '33';
    SOURCE_COMPATIBILITY = 'VERSION_11';
    TARGET_COMPATIBILITY = 'VERSION_11';
    RN_GRADLE_PLUGIN_VERSION = '0.72.11';
  • Update from legacy codgen to new @react-native/codegen package from RN.

IOS

@rthic23 rthic23 requested review from friederbluemle and leekuo June 12, 2024 20:13
@rthic23 rthic23 force-pushed the upgrade-rn-0.72 branch 2 times, most recently from 15cf548 to 851cf68 Compare June 12, 2024 23:30
Copy link
Member

@leekuo leekuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, everything looks just like the RN upgrade helper

Copy link
Member

@friederbluemle friederbluemle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Karthic! Overall looks good, but let's discuss some of the details tomorrow! 👍

yarn.lock Show resolved Hide resolved
@rthic23 rthic23 force-pushed the upgrade-rn-0.72 branch 2 times, most recently from 56915d5 to a8dda82 Compare June 14, 2024 05:40
@rthic23 rthic23 requested a review from friederbluemle July 1, 2024 16:52
@rthic23 rthic23 changed the title Upgrade ERN to support RN 0.72.14 Upgrade ERN to support RN 0.72 Jul 12, 2024
@rthic23 rthic23 force-pushed the upgrade-rn-0.72 branch 4 times, most recently from 00c9dc6 to 35e3a32 Compare July 17, 2024 18:56
Copy link
Member

@friederbluemle friederbluemle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @rthic23 👍

@rthic23 rthic23 merged commit 5880526 into electrode-io:master Jul 26, 2024
10 checks passed
@rthic23 rthic23 deleted the upgrade-rn-0.72 branch July 26, 2024 01:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants