-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade ERN to support RN 0.72 #1906
Conversation
15cf548
to
851cf68
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, everything looks just like the RN upgrade helper
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Karthic! Overall looks good, but let's discuss some of the details tomorrow! 👍
56915d5
to
a8dda82
Compare
00c9dc6
to
35e3a32
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @rthic23 👍
ANDROID
DEFAULT_RN_GRADLE_PLUGIN_VERSION = '0.72.11';
ANDROID_GRADLE_PLUGIN_VERSION = '7.4.2';
ANDROIDX_APPCOMPACT_VERSION = '1.1.0';
ANDROIDX_LIFECYCLE_EXTENSIONS_VERSION = '2.1.0';
BUILD_TOOLS_VERSION = '33.0.0';
COMPILE_SDK_VERSION = '33';
GRADLE_DISTRIBUTION_VERSION = '8.0.1';
JSC_VARIANT = 'android-jsc';
KOTLIN_VERSION = '1.7.22';
MIN_SDK_VERSION_PRE_RN64 = '19';
MIN_SDK_VERSION_POST_RN64 = '21';
SUPPORT_LIBRARY_VERSION = '28.0.0';
TARGET_SDK_VERSION = '33';
SOURCE_COMPATIBILITY = 'VERSION_11';
TARGET_COMPATIBILITY = 'VERSION_11';
RN_GRADLE_PLUGIN_VERSION = '0.72.11';
IOS