Add support for MySQL storage #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jchip
reviewed
Jan 5, 2018
| { | ||
| "name": "electrode-ota-server-dao-factory", | ||
| "version": "3.0.0", | ||
| "description": "OTA DAO", |
There was a problem hiding this comment.
add author, repository, license, bugs
|
|
||
| const nullUnlessValue = (obj, keys) => { | ||
| for (const key of keys) { | ||
| if (obj[key] === void(0)) { |
There was a problem hiding this comment.
you want to null properties that do not exist also?
don't like undefined?
I think objDefaultNull is slightly more telling.
| @@ -0,0 +1,7 @@ | |||
| # THIS IS AN AUTOGENERATED FILE. DO NOT EDIT THIS FILE DIRECTLY. | |||
There was a problem hiding this comment.
can't make your mind about yarn or npm? :)
| @@ -0,0 +1,23 @@ | |||
| { | |||
jchip
reviewed
Jan 5, 2018
| import _ from 'lodash'; | ||
| import {Sequelize} from 'sequelize'; | ||
| import {ProxyModelWrapper} from './proxy'; | ||
| import cls from 'continuation-local-storage'; |
There was a problem hiding this comment.
This. Will. Be. Your. Worst. Nightmare.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for MySQL/MariaDB as the data store.