Pass userConfig to loadConfigs #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thanks for the PR. @animesh10 please review. |
|
Looks good! |
jeffrifwald
pushed a commit
to jeffrifwald/electrode
that referenced
this pull request
Jan 23, 2017
…solverEngine Remove default require for routerResolverEngine
This was referenced Feb 2, 2024
This was referenced Feb 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like the generator is not passing through the userConfigs from the calling of the server to loadConfigs. loadConfigs signature takes in userConfigs, but as it is right now always gets an empty config object. The entry point for the module is passed the userConfigs, so this pull is just actually getting it to the loadConfigs method, via the Promise.resolve.