Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: migrating electrode repo to use rush mono-repo tooling #1946

Merged
merged 33 commits into from
Mar 28, 2023
Merged

chore: migrating electrode repo to use rush mono-repo tooling #1946

merged 33 commits into from
Mar 28, 2023

Conversation

arunvishnun
Copy link
Contributor

@arunvishnun arunvishnun commented Jan 20, 2023 •
edited
Loading

Summary

This PR includes all changes to migrate the mono-repo tooling to rushjs

Below are the changes introduced on a high level:

  • devDependency upgrades to suite rush's requirements
  • github workflow changes for rush
  • Version Policy (lockStep) for @xarc/app and @xarc/app-dev. This is to keep these package versions always in sync
  • Node 16 support in ci jobs.
  • Contribution guideline changes
  • eslint fixes
  • Re-generated Docusaurus docs with updated dependencies
  • Commitlint to enforce conventional commits

Package Details

  • electrode-archetype-webpack-dll-dev - Dev dependency update / patch

  • electrode-cdn-file-loader - Minor script update, no release needed

  • electrode-cookies - Test updates - no release needed

  • electrode-node-resolver - No release needed

  • electrode-react-webapp - babel/* minor version upgrades / minor

  • electrode-ui-config - export missing fastify config / minor

  • electrode-ui-logger - Add @xarc/run to dev dependency/ patch

  • opt-archetype-check - No release needed

  • subapp-pbundle - Add @xarc/run to dev dependency/ patch

  • subapp-pkg-util - No release needed

  • subapp-react- optional-require patch upgrade / patch

  • subapp-redux - Add @xarc/run to dev dependency/ patch

  • subapp-server - Add phantom dependency @xarc/render-context. Add @xarc/run to dev dependency / minor

  • subapp-util - No release needed

  • subapp-web - Dev dependencies added and test updates / patch

  • webpack-config-composer - typescript minor version upgrade / minor

  • xarc-app-dev - fix: types error in xarc-app-dev package / minor

  • xarc-app - add @xarc/run to dev dependency/ patch

  • xarc-create-app -webpack upgrade to 5 and and webpack-cli major version upgrades to 4/ major

  • xarc-dev-base - Add @xarc/run to devDependency / patch

  • xarc-index-page - Adds phantom dependencies loadash and require-at / minor

  • xarc-jsx-renderer - Add @xarc/run to dev dependency / patch

  • xarc-opt-eslint - Update dev dependency - opt-archetype-check / patch

  • xarc-opt-jest - Update dev dependency - opt-archetype-check / patch

  • xarc-opt-karma - Update dev dependency - opt-archetype-check / patch

  • xarc-opt-less - Update dev dependency - opt-archetype-check / patch

  • xarc-opt-mocha - Update dev dependency - opt-archetype-check / patch

  • xarc-opt-postcss - Update dev dependency - opt-archetype-check / patch

  • xarc-opt-preact - Update dev dependency - opt-archetype-check / patch

  • xarc-opt-react - Update dev dependency - opt-archetype-check / patch

  • xarc-opt-sass - Update dev dependency - opt-archetype-check / patch

  • xarc-opt-stylus - Update dev dependency - opt-archetype-check / patch

  • xarc-react-query - Update dev dependency - @types/react / patch

  • xarc-react-recoil - Upgrade recoil and remove @types/recoil as recoil provides its own type definitions / Minor

  • xarc-react-redux-observable - Upgrade dev dependencies - @types/react, @types/react-dom / minor

  • xarc-react-redux-saga - Upgrade dev dependencies - @types/react, @types/react-dom / minor

  • xarc-react-redux - Upgrade dev dependencies - typescript, @types/react, @types/react-dom / minor

  • xarc-react-router - Upgrade dev dependencies -@types/mocha, ts-node, typescript / minor

  • xarc-react - Upgrade dev dependencies - @types/react / minor

  • xarc-render-context - add @xarc/run to devDependency/ patch

  • xarc-subapp - add @xarc/run to dev dependency / patch

  • xarc-tag-renderer - Adds phantom dependencies loadash/patch

  • xarc-webpack - webpack minimum minor version upgrade from ^5.74 to ^5.75, dev dependency upgrade for @types/chai and @types/mocha / minor

@arunvishnun arunvishnun marked this pull request as ready for review January 24, 2023 00:15
shubham2811
shubham2811 approved these changes Feb 2, 2023
View reviewed changes
Copy link
Contributor

@shubham2811 shubham2811 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ashuverma and others added 22 commits March 23, 2023 21:37
@ashuverma @arunvishnun
[WIP] Use rush + pnpm for managing monorepo (electrode-io#1907)
55d26c6 
* Add rush config files

* Add few projects for testing install and build

 Author:    Ashu Verma <ashuverma@outlook.com>

* Update Github Workflow to use rush

* Add all the packages and fix dependencies

Include All the packages in the repo into rush.
Fix missing build scripts.
Add missing dependencies.

* Enabling tests. All of them still don't work
@smuthya @srinathm85
@mristic505 @arunvishnun
add node 16 in ci (electrode-io#1901)
ef8391f 
* add node 16 in ci

* [fix]: upgrade xarc-opt-sass to pass node 16 build (electrode-io#1902)

Co-authored-by: Srinath Muthyala <Srinath.reddy.muthyala@walmart.com>
Co-authored-by: mristic505 <mateja.ristic@gmail.com>
@arunvishnun
Update github action and fix tests (electrode-io#1910)
fb0eaff 
* Update github action and adding in several test fixes with rush

Co-authored-by: Arun Vishnu <arunnampoothiri.vish@walmart.com>
@arunvishnun @SRHerzog
@ashuverma @srinathm85 @mristic505
feat: merge changes from master and fix poc-subapp (electrode-io#1919)
c05a970 
* add two options for improving webpack performance (electrode-io#1904)

Co-authored-by: Steve Herzog <vn54bh8@m-c02xf19ujgh7.homeoffice.wal-mart.com>

* feature: open browser when proxy is ready (electrode-io#1905)

Co-authored-by: Steve Herzog <vn54bh8@m-c02xf19ujgh7.homeoffice.wal-mart.com>

* Fix broken reporter link (electrode-io#1908)

* Update changelog

* [Publish]

 - @xarc/app@11.0.1
 - @xarc/app-dev@11.0.1
 - @xarc/webpack@11.1.3

* Upgrade poc-subapp and poc-subapp-redux to react18 with rr6 (electrode-io#1913)

* Upgrade POC-SUBAPP-REDUX to React 18 and RR6

* Upgrade poc-subapp to react 16 and RR6

* fix types issues in multiple packages (electrode-io#1918)

* fix types issues in multiple packages

Co-authored-by: Arun Vishnu <arunnampoothiri.vish@walmart.com>

* fix: poc-subapp and merge changes from master

* fix: update devtool to use eval-cheap-module-source-map

* chore: remove debug statement

Co-authored-by: Steve Herzog <srherzog@gmail.com>
Co-authored-by: Steve Herzog <vn54bh8@m-c02xf19ujgh7.homeoffice.wal-mart.com>
Co-authored-by: Ashu Verma <ashuverma@outlook.com>
Co-authored-by: smuthya <srinath.reddy.muthyala@walmart.com>
Co-authored-by: mristic505 <mateja.ristic@gmail.com>
Co-authored-by: Arun Vishnu <arunnampoothiri.vish@walmart.com>
@arunvishnun @mristic505
fix poc subapp redux when running with rushx (electrode-io#1920)
9e07f1b 
* Upgrade poc-subapp and poc-subapp-redux to react18 with rr6 (electrode-io#1913)

* Upgrade POC-SUBAPP-REDUX to React 18 and RR6

* Upgrade poc-subapp to react 16 and RR6

* fix types issues in multiple packages (electrode-io#1918)

* fix types issues in multiple packages

Co-authored-by: Arun Vishnu <arunnampoothiri.vish@walmart.com>

* fix: sample app - poc-subapp-redux

* chore: pnpm-lock updated

* fix: incorrect filename reference in the import statement

* fix: incorrect filename reference in the import statement

Co-authored-by: mristic505 <mateja.ristic@gmail.com>
Co-authored-by: Arun Vishnu <arunnampoothiri.vish@walmart.com>
@arunvishnun
feat: add commitlint configs (electrode-io#1921)
776374f
@arunvishnun
docs: documentation updates (electrode-io#1922)
0891ab3 
* docs: update readme and contribution guidelines

* docs: documentation and contribution guidelines updated

* docs: update release guidelines

* docs: update release guidelines
@arunvishnun
chore: testing package publish flow (electrode-io#1925)
5c01867 
* fix: update message log

* fix: update message log

* fix: update message log
@arunvishnun
cleanup (electrode-io#1927)
fef001f 
* fix: publish flow

* fix: clean up
@arunvishnun
rush test publish package (electrode-io#1928)
10ec000 
* feat: message update - test rush publish

* feat: message update - test rush publish
@arunvishnun
chore: bump versions [skip ci] (electrode-io#1929)
7f8daf7
@arunvishnun
developer flow - change file creation - test (electrode-io#1930)
cfd5414 
* feat: message update - test rush publish

* chore: rush change commit
@arunvishnun
chore: delete test packages created to test publish flow with rush (e…
bf6741f 
…lectrode-io#1931)
@arunvishnun
docs: update package publishing process with rush (electrode-io#1933)
2848dfc 
* Publishtest (#7)

* feat: add a new test package for publish test

* chore: new package to test publish operation - commiting change files

* chore: bump versions [skip ci]

* docs: update package publishing process with rush

* chore: remove unused files

* chore: remove unused files

* chore: update shrinkwrap file
@arunvishnun
docs: update documentation with commitlint details (electrode-io#1934)
4b42459 
* docs: update documentation with commitlint details
@arunvishnun
feat: rebase rush changes with master
669fcc4
@arunvishnun
docs: update documentations
7ff130a
@arunvishnun
fix: webpack version inconsistency issues
c10b580
@arunvishnun
chore: enable temporarly commented lines in rush branch
90386e8
@arunvishnun
chore: uncommenting a test case and un necessary console.log
149da01
@arunvishnun
chore: use rever to use clap keep minimal changes against master branch
84d6537
@arunvishnun
chore: use mocha config same as master branch
eee2178
@arunvishnun
chore: changelog jsons from rush change
91c3ae8
@arunvishnun
fix: types error in xarc-app-dev package (#8)
1984be5 
* fix: types error in xarc-app-dev package

* docs: update to contribution guidelines

* docs: update to contribution guidelines
@arunvishnun
fix: eslint issues in sample apps (#9)
68de0cb
@arunvishnun
fix: test issues in sample apps (#10)
3493396 
* fix: test issues in sample apps

* fix: test issues in sample apps
@arunvishnun
chore: allow warnings in successful builds (#11)
6ec5ce7 
* fix: test issues in sample apps

* fix: test issues in sample apps

* chore: allow warnings in successful builds

* chore: allow warnings in successful builds
@arunvishnun
fix: tests for node 12 (#12)
45f4e9d 
* fix: test issues in sample apps

* fix: test issues in sample apps

* fix: tests for node 12
@arunvishnun
test: fix unit test failing in subapp-web@2
13638f0
@smuthya smuthya self-requested a review March 28, 2023 15:51
@arunvishnun arunvishnun merged commit 711d5c3 into electrode-io:master Mar 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shubham2811 shubham2811 shubham2811 approved these changes

@smuthya smuthya smuthya approved these changes

@chandub chandub Awaiting requested review from chandub

@divyakarippath divyakarippath Awaiting requested review from divyakarippath

@kylejeske kylejeske Awaiting requested review from kylejeske

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@arunvishnun @shubham2811 @smuthya @ashuverma