Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add is registered #82

Merged
merged 2 commits into from
Aug 27, 2020
Merged

Add is registered #82

merged 2 commits into from
Aug 27, 2020

Conversation

deepueg
Copy link
Contributor

@deepueg deepueg commented Aug 27, 2020

This PR adds isRegistered api to RequestHandle. This helps the consuming app to validate if a given request handler instance is still valid or it's already removed by a new request handler instance or removed via a call to unregister().

This helps clients to validate a request handler's state
Added tests
@deepueg deepueg requested a review from friederbluemle August 27, 2020 19:28
Copy link
Member

@friederbluemle friederbluemle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks @deepueg 👍

@deepueg deepueg merged commit 5a3b301 into electrode-io:master Aug 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants