Integrate ESLint and Prettier #92

friederbluemle · 2023-01-14T01:59:14Z

ESLint with @react-native-community config fully integrated and now running on CI.

The original commit dates back to November 2019, updated to work with eslint@^7/@react-native-community/eslint-config@^2

Also includes one commit that fixes usage of non-existent constants (previously undetected, as we did not run any checks).

rthic23

lgtm. possible to fix the failing CI build?

friederbluemle · 2023-01-14T22:56:19Z

lgtm. possible to fix the failing CI build?

Yes, will definitely make sure CI is green before merge. 👍

friederbluemle · 2023-01-17T01:10:55Z

CI is passing now. The issue was due to automatic line ending conversion on Windows 🤦

Disabled it via:

      - if: runner.os == 'Windows'
        run: |
          git config --global core.autocrlf false
          git config --global core.eol lf

rthic23 approved these changes Jan 14, 2023

View reviewed changes

friederbluemle and others added 3 commits January 16, 2023 16:20

Integrate ESLint and Prettier

8356e98

Auto-fix ESLint errors and formatting

86d5976

Fix usage of undefined constants for dispatchEvent

539efad

friederbluemle force-pushed the eslint branch from bcc609b to 5e43c32 Compare January 17, 2023 00:42

Run ESLint and Prettier on CI

fb845da

friederbluemle force-pushed the eslint branch from 5e43c32 to fb845da Compare January 17, 2023 00:57

friederbluemle merged commit d6966d6 into electrode-io:master Jan 17, 2023

friederbluemle deleted the eslint branch January 17, 2023 01:11

Provide feedback