fix: codesign all binary-like files (#5322)

electron-userland · Nov 28, 2020 · 27ea1b2 · 27ea1b2
1 parent 069eba1
commit 27ea1b2
Showing 1 changed file with 1 addition and 12 deletions.
diff --git a/packages/app-builder-lib/electron-osx-sign/util.js b/packages/app-builder-lib/electron-osx-sign/util.js
@@ -202,23 +202,12 @@ module.exports.walkAsync = async function (dirPath) {
       const stat = await fs.lstat(filePath)
       if (stat.isFile()) {
         switch (path.extname(filePath)) {
-          case '': // Binary
-            if (path.basename(filePath)[0] !== '.') {
-              return getFilePathIfBinaryAsync(filePath)
-            } // Else reject hidden file
-            break
-          case '.dylib': // Dynamic library
-          case '.node': // Native node addon
-            return filePath
           case '.cstemp': // Temporary file generated from past codesign
             debuglog('Removing... ' + filePath)
             await fs.unlink(filePath)
             return
           default:
-            if (path.extname(filePath).indexOf(' ') >= 0) {
-              // Still consider the file as binary if extension seems invalid
-              return getFilePathIfBinaryAsync(filePath)
-            }
+            return getFilePathIfBinaryAsync(filePath)
         }
       } else if (stat.isDirectory() && !stat.isSymbolicLink()) {
         const result = await _walkAsync(filePath)