fix(mac): signing NSIS on mac (#8090)

electron-userland · Mar 2, 2024 · 2c147ad · 2c147ad
1 parent 18340ee
commit 2c147ad
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 7 deletions.
diff --git a/.changeset/eighty-bobcats-eat.md b/.changeset/eighty-bobcats-eat.md
@@ -0,0 +1,5 @@
+---
+"app-builder-lib": patch
+---
+
+fix(mac): sign NSIS on mac
diff --git a/packages/app-builder-lib/src/codeSign/windowsCodeSign.ts b/packages/app-builder-lib/src/codeSign/windowsCodeSign.ts
@@ -56,14 +56,18 @@ export async function sign(options: WindowsSignOptions, packager: WinPackager):
   let isNest = false
   for (const hash of hashes) {
     const taskConfiguration: WindowsSignTaskConfiguration = { ...options, hash, isNest }
-    const config: CustomWindowsSignTaskConfiguration = {
-      ...taskConfiguration,
-      computeSignToolArgs: isWin => computeSignToolArgs(taskConfiguration, isWin),
-    }
-    await Promise.resolve(executor(config, packager))
+    await Promise.resolve(
+      executor(
+        {
+          ...taskConfiguration,
+          computeSignToolArgs: isWin => computeSignToolArgs(taskConfiguration, isWin),
+        },
+        packager
+      )
+    )
     isNest = true
-    if (config.resultOutputPath != null) {
-      await rename(config.resultOutputPath, options.path)
+    if (taskConfiguration.resultOutputPath != null) {
+      await rename(taskConfiguration.resultOutputPath, options.path)
     }
   }