Skip to content

Commit

Permalink
fix(osx): Code signing might need proxy to reach internet (#2702)
Browse files Browse the repository at this point in the history
Close #2701
  • Loading branch information
johvo authored and develar committed Mar 17, 2018
1 parent 858967b commit 68f31dc
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions packages/electron-builder-lib/src/windowsCodeSign.ts
Original file line number Diff line number Diff line change
Expand Up @@ -241,6 +241,10 @@ function computeSignToolArgs(options: WindowsSignTaskConfiguration, isWin: boole
args.push(isWin ? "/ac" : "-ac", vm.toVmFile(options.options.additionalCertificateFile))
}

if (!isWin && process.env.HTTPS_PROXY) {
args.push("-p", process.env.HTTPS_PROXY)
}

if (isWin) {
// must be last argument
args.push(inputFile)
Expand Down

0 comments on commit 68f31dc

Please sign in to comment.