chore: Rename vmRequired variable to useVmIfNotOnWin (#8727)

electron-userland · Dec 6, 2024 · 7268c2e · 7268c2e
1 parent 6633450
commit 7268c2e
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 3 deletions.
diff --git a/.changeset/shy-pumas-attack.md b/.changeset/shy-pumas-attack.md
@@ -0,0 +1,5 @@
+---
+"app-builder-lib": patch
+---
+
+chore: Rename `vmRequired` variable to `useVmIfNotOnWin`
diff --git a/packages/app-builder-lib/src/codeSign/windowsSignToolManager.ts b/packages/app-builder-lib/src/codeSign/windowsSignToolManager.ts
@@ -438,11 +438,11 @@ export class WindowsSignToolManager implements SignManager {
     let args: Array<string>
     let env = process.env
     let vm: VmManager
-    const vmRequired = configuration.path.endsWith(".appx") || !("file" in configuration.cscInfo!) /* certificateSubjectName and other such options */
-    const isWin = process.platform === "win32" || vmRequired
+    const useVmIfNotOnWin = configuration.path.endsWith(".appx") || !("file" in configuration.cscInfo!) /* certificateSubjectName and other such options */
+    const isWin = process.platform === "win32" || useVmIfNotOnWin
     const toolInfo = await this.getToolPath(isWin)
     const tool = toolInfo.path
-    if (vmRequired) {
+    if (useVmIfNotOnWin) {
       vm = await packager.vm.value
       args = this.computeSignToolArgs(configuration, isWin, vm)
     } else {